This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][BZ #15346] Allow leading and trailing spaces in getdate


> +  /* Skip leading spaces.  */

s/spaces/whitespace/

> +  while (string[i] && isspace (string[i]))
> +    i++;

Avoid Boolean coercion: string[i] != '\0'.
But since you've already done strlen, why not i < inlen?

> +  /* Skip trailing spaces.  */

s/spaces/whitespace/

> +  char *instr;
> +  if (__libc_use_alloca (inlen + 1))
> +    {
> +      instr = alloca (inlen + 1);
> +    }

Drop the braces here.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]