This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH v2 1/2] Add MicroBlaze support to elf/elf.h


> -----Original Message-----
> From: Roland McGrath [mailto:roland@hack.frob.com]
> Sent: Tuesday, 9 April 2013 8:15 am
> To: David Holsgrove
> Cc: libc-alpha@sourceware.org; libc-ports@sourceware.org;
> joseph@codesourcery.com; John Williams; Edgar Iglesias; Vinod Kathail;
> Vidhumouli Hunsigida; Nagaraju Mekala; Tom Shui
> Subject: Re: [PATCH v2 1/2] Add MicroBlaze support to elf/elf.h
> Importance: High
> 
> > +#define EM_MICROBLAZE	189		/* Xilinx MicroBlaze 32-bit RISC
> soft processor core */
> 
> Just "Xilinx MicroBlaze" is enough here, and keeps the line from getting
> too long.
> 
> If all the R_MICROBLAZE_* macros match the names and values in trunk
> binutils (and those in your psABI document), then this change is OK
> with the comment change above.

Thanks Roland, I've updated the comment as suggested.

The relocation macro names and values for MicroBlaze match those
I submitted to trunk binutils.

thanks,
David

> 
> 
> Thanks,
> Roland



Attachment: 0001-Adding-MicroBlaze-support-to-elf-elf h.patch
Description: 0001-Adding-MicroBlaze-support-to-elf-elf h.patch


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]