This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nscd: don't fork twice
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: libc-alpha at sourceware dot org
- Cc: Alexandre Oliva <aoliva at redhat dot com>, Andreas Jaeger <aj at suse dot com>
- Date: Thu, 11 Apr 2013 15:26:09 -0700 (PDT)
- Subject: Re: [PATCH] nscd: don't fork twice
- References: <mvmip3uzitx dot fsf at hawking dot suse dot de>
Is there a BZ# about this? Does the extra fork cause any known harm?
Alex and AJ did the change that added it. Perhaps they can confirm
that it was a mistake, or else explain the rationale for adding it.
Limiting setsid to daemon mode is a separate issue and should be a
separate change. Your new comment is not necessarily true: it's
possible that nscd --foreground was exec'd in a process that is not a
process group leader, so setsid could succeed. If the setsid call is
to be elided for RUN_FOREGROUND, then the comment in the enum
definition should change not to say "detach from terminal".
Thanks,
Roland