This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add benchmark inputs for cos and tan
- From: Andreas Jaeger <aj at suse dot com>
- To: libc-alpha at sourceware dot org
- Date: Wed, 17 Apr 2013 13:51:31 +0200
- Subject: Re: [PATCH] Add benchmark inputs for cos and tan
- References: <20130417094703 dot GJ3367 at spoyarek dot pnq dot redhat dot com> <9981726 dot xhFoHlcYON at byrd> <20130417112946 dot GC10160 at spoyarek dot pnq dot redhat dot com>
On Wednesday, April 17, 2013 16:59:46 Siddhesh Poyarekar wrote:
> On Wed, Apr 17, 2013 at 01:18:29PM +0200, Andreas Jaeger wrote:
> > > +# cos function fast path
> >
> > since we might have different implementations, shouldn't we add the
> > file name you're talking about?
>
> I'm sorry I don't understand. You mean mention the file name of the
> implementation I'm testing in the comment? Something like:
>
> # cos function fast path: Implemented in
> sysdeps/ieee754/dbl-64/s_sin.c
Yes, that would be one way to do it.
My suggestion was to document which file has a fast/slow path - since
there can be different implementations,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126