This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Move x86_64-specific audit tests to sysdeps/x86_64/
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 25 Apr 2013 13:16:47 -0400
- Subject: Re: Move x86_64-specific audit tests to sysdeps/x86_64/
- References: <Pine dot LNX dot 4 dot 64 dot 1304251553500 dot 8948 at digraph dot polyomino dot org dot uk>
On 04/25/2013 11:54 AM, Joseph S. Myers wrote:
> Various x86_64-specific audit tests are located in the elf/ directory,
> with associated makefile code in elf/Makefile. This patch moves them
> to sysdeps/x86_64 where they belong, as part of the process of making
> libc architectures more like ports architectures regarding
> architecture-specific code going in sysdeps rather than direct in
> generic files. Tested x86_64.
>
> (I don't know if any of these tests would be applicable to 32-bit x86
> builds as well; this patch simply preserves the status quo that they
> run on x86_64 only, while moving them to a more appropriate location.)
>
> 2013-04-25 Joseph Myers <joseph@codesourcery.com>
>
> * elf/Makefile [$(config-machine) = x86_64] (tests): Remove
> additions to variable.
> [$(config-machine) = x86_64] (modules-names): Likewise.
> ($(objpfx)tst-audit3): Remove dependency.
> ($(objpfx)tst-audit3.out): Likewise.
> ($(objpfx)tst-audit4): Likewise.
> ($(objpfx)tst-audit4.out): Likewise.
> ($(objpfx)tst-audit5): Likewise.
> ($(objpfx)tst-audit5.out): Likewise.
> ($(objpfx)tst-audit6): Likewise.
> ($(objpfx)tst-audit6.out): Likewise.
> ($(objpfx)tst-audit7): Likewise.
> ($(objpfx)tst-audit7.out): Likewise.
> (tst-audit3-ENV): Remove variable.
> (tst-audit4-ENV): Likewise.
> (tst-audit5-ENV): Likewise.
> (tst-audit6-ENV): Likewise.
> (tst-audit7-ENV): Likewise.
> [$(config-cflags-avx) = yes] (AVX-CFLAGS): Likewise.
> [$(config-cflags-avx) = yes] (CFLAGS-tst-audit4.c): Remove
> addition to variable.
> [$(config-cflags-avx) = yes] (CFLAGS-tst-auditmod4a.c): Likewise.
> [$(config-cflags-avx) = yes] (CFLAGS-tst-auditmod4b.c): Likewise.
> [$(config-cflags-avx) = yes] (CFLAGS-tst-auditmod6b.c): Likewise.
> [$(config-cflags-avx) = yes] (CFLAGS-tst-auditmod6c.c): Likewise.
> [$(config-cflags-avx) = yes] (CFLAGS-tst-auditmod7b.c): Likewise.
> * sysdeps/x86_64/Makefile [$(subdir) = elf] (tests): Add
> tst-audit3, tst-audit4 and tst-audit5.
> [$(subdir) = elf && $(config-cflags-avx) = yes] (tests): Add
> tst-audit6 and tst-audit7.
> [$(subdir) = elf] (modules-names): Add audit modules for those
> tests.
> [$(subdir) = elf] ($(objpfx)tst-audit3): New dependency.
> [$(subdir) = elf] ($(objpfx)tst-audit3.out): Likewise.
> [$(subdir) = elf] ($(objpfx)tst-audit4): Likewise.
> [$(subdir) = elf] ($(objpfx)tst-audit4.out): Likewise.
> [$(subdir) = elf] ($(objpfx)tst-audit5): Likewise.
> [$(subdir) = elf] ($(objpfx)tst-audit5.out): Likewise.
> [$(subdir) = elf] ($(objpfx)tst-audit6): Likewise.
> [$(subdir) = elf] ($(objpfx)tst-audit6.out): Likewise.
> [$(subdir) = elf] ($(objpfx)tst-audit7): Likewise.
> [$(subdir) = elf] ($(objpfx)tst-audit7.out): Likewise.
> [$(subdir) = elf] (tst-audit3-ENV): New variable.
> [$(subdir) = elf] (tst-audit4-ENV): Likewise.
> [$(subdir) = elf] (tst-audit5-ENV): Likewise.
> [$(subdir) = elf] (tst-audit6-ENV): Likewise.
> [$(subdir) = elf] (tst-audit7-ENV): Likewise.
> [$(subdir) = elf && $(config-cflags-avx) = yes] (AVX-CFLAGS):
> Likewise.
> [$(subdir) = elf && $(config-cflags-avx) = yes]
> (CFLAGS-tst-audit4.c): Append $(AVX-CFLAGS).
> [$(subdir) = elf && $(config-cflags-avx) = yes]
> (CFLAGS-tst-auditmod4a.c): Likewise.
> [$(subdir) = elf && $(config-cflags-avx) = yes]
> (CFLAGS-tst-auditmod4b.c): Likewise.
> [$(subdir) = elf && $(config-cflags-avx) = yes]
> (CFLAGS-tst-auditmod6b.c): Likewise.
> [$(subdir) = elf && $(config-cflags-avx) = yes]
> (CFLAGS-tst-auditmod6c.c): Likewise.
> [$(subdir) = elf && $(config-cflags-avx) = yes]
> (CFLAGS-tst-auditmod7b.c): Likewise.
> * elf/tst-audit3.c: Move to ...
> * sysdeps/x86_64/tst-audit3.c: ... here.
> * elf/tst-audit4.c: Move to ...
> * sysdeps/x86_64/tst-audit4.c: ... here.
> * elf/tst-audit5.c: Move to ...
> * sysdeps/x86_64/tst-audit5.c: ... here.
> * elf/tst-audit6.c: Move to ...
> * sysdeps/x86_64/tst-audit6.c: ... here.
> * elf/tst-audit7.c: Move to ...
> * sysdeps/x86_64/tst-audit7.c: ... here.
> * elf/tst-auditmod3a.c: Move to ...
> * sysdeps/x86_64/tst-auditmod3a.c: ... here.
> * elf/tst-auditmod3b.c: Move to ...
> * sysdeps/x86_64/tst-auditmod3b.c: ... here.
> * elf/tst-auditmod4a.c: Move to ...
> * sysdeps/x86_64/tst-auditmod4a.c: ... here.
> * elf/tst-auditmod4b.c: Move to ...
> * sysdeps/x86_64/tst-auditmod4b.c: ... here.
> * elf/tst-auditmod5a.c: Move to ...
> * sysdeps/x86_64/tst-auditmod5a.c: ... here.
> * elf/tst-auditmod5b.c: Move to ...
> * sysdeps/x86_64/tst-auditmod5b.c: ... here.
> * elf/tst-auditmod6a.c: Move to ...
> * sysdeps/x86_64/tst-auditmod6a.c: ... here.
> * elf/tst-auditmod6b.c: Move to ...
> * sysdeps/x86_64/tst-auditmod6b.c: ... here.
> * elf/tst-auditmod6c.c: Move to ...
> * sysdeps/x86_64/tst-auditmod6c.c: ... here.
> * elf/tst-auditmod7a.c: Move to ...
> * sysdeps/x86_64/tst-auditmod7a.c: ... here.
> * elf/tst-auditmod7b.c: Move to ...
> * sysdeps/x86_64/tst-auditmod7b.c: ... here.
This looks good to me.
Cheers,
Carlos.