This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #14412] Define __sincos_finite as a fast version of sincos
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha at sourceware dot org, libc-ports at sourceware dot org
- Date: Mon, 29 Apr 2013 15:31:45 +0200
- Subject: Re: [PATCH][BZ #14412] Define __sincos_finite as a fast version of sincos
- References: <20130429102739 dot GE1330 at spoyarek dot pnq dot redhat dot com>
Siddhesh Poyarekar <siddhesh@redhat.com> writes:
> This patch brings back the assembly implementation of sincos (with
> some changes) to give a fast alternative to the default sincos
> implementation. This is defined as __sincos_finite and is used if the
> implementing program is compiled with the -ffinite-math-only gcc flag.
This is the wrong approach. The bug is not about not handling Inf or
NaN in sincos, but allowing inaccurate result from certain finite
numbers. The -ffinite-math-only switch does not cover the latter.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."