This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH rsa/stdint] Cleanup: Add #include <stdint.h> for uint[32|64]_t usage
- From: Roland McGrath <roland at hack dot frob dot com>
- To: rsa at us dot ibm dot com
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 29 Apr 2013 18:54:51 -0700 (PDT)
- Subject: Re: [PATCH rsa/stdint] Cleanup: Add #include <stdint.h> for uint[32|64]_t usage
- References: <1364493171 dot 3473 dot 23 dot camel at localhost dot localdomain> <20130328191637 dot 163BA2C0A1 at topped-with-meat dot com> <1367280050 dot 9067 dot 269 dot camel at localhost dot localdomain>
Your log entry includes ports/* files that get their logs in
separate ports/ChangeLog.* files.
There might be some of these where it really is kosher without explicitly
including <stdint.h> because of some other header whose official API
includes making sure those types are around (e.g. <sys/types.h> but I'm
pretty sure there are also less-obvious cases). But it doesn't hurt to
add it in those cases, excepting installed headers.
Each case in an installed header needs more scrutiny. Please separate out
the change into a big one that doesn't touch any installed header. That
can go in without further approval, trusting you to take more care about
the ChangeLog details. Then for each case in an installed header, we need
to contemplate the API details and see what the right solution really is.
So let's take those one case at a time with separate patches. (Here I mean
e.g. all sysdeps/*/bits/link.h to be "one case".)
Thanks,
Roland