This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #15465] Avoid crashing with LD_DEBUG=symbols when program name is unavailable
- From: Andreas Jaeger <aj at suse dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha at sourceware dot org, libc-ports at sourceware dot org
- Date: Tue, 14 May 2013 15:35:19 +0200
- Subject: Re: [PATCH][BZ #15465] Avoid crashing with LD_DEBUG=symbols when program name is unavailable
- References: <20130514103124 dot GN25336 at spoyarek dot pnq dot redhat dot com>
On 05/14/2013 12:31 PM, Siddhesh Poyarekar wrote:
Hi,
The program name may be unavailable if the user application tampers
with argc and argv[]. Some parts of the dynamic linker check this
while others don't, so this patch consolidates the check and fallback
into a single macro and updates all users. I have also added a simple
test to verify the fix and have also verified that this does not
result in any regressions in the testsuite.
I have made mechanical changes to architectures other than x86 (even
in ports), that I haven't tested. Could the maintainers test and give
feedback?
Wow, the checking was really inconsistent throughout the code. I
reviewed the changes and they look fine to me,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126