This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix parsing of numeric hosts in gethostbyname_r
- From: Andreas Jaeger <aj at suse dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 17 May 2013 09:42:20 +0200
- Subject: Re: [PATCH] Fix parsing of numeric hosts in gethostbyname_r
- References: <mvm61zuzill dot fsf at hawking dot suse dot de>
On 04/10/2013 02:16 PM, Andreas Schwab wrote:
A couple of thing are going wrong in __nss_hostname_digits_dots:
- the computed size is too small
- useless duplication of local variables in an inner scope
- when called from reentrant functions it needs to set the NSS status,
and the caller should not override h_errno
Andreas.
[BZ #15014]
The patch itself is fine but I wonder whether we can add a regression
test to the testsuite. There's a test in bugzilla, is it possible to use
that for a proper test case?
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126