This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] libm-test.inc: Correctly implement ulp().
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: Andreas Jaeger <aj at suse dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 17 May 2013 20:34:52 +0000
- Subject: Re: [PATCH] libm-test.inc: Correctly implement ulp().
- References: <5195593A dot 7090202 at redhat dot com> <51968072 dot 2090606 at suse dot com> <51968291 dot 2010707 at redhat dot com>
On Fri, 17 May 2013, Carlos O'Donell wrote:
> >> ulp(x) : 4.94065645841246544177e-324 0x0.00000000000010000000p-1022
> >
> > While I understand why you print this out for explanation, I consider
> > this more a debugging output and propose to not output "ulp(x)" at
> > all, I fear it confuses only.
>
> I'm happy to remove it if people think it's just clutter.
>
> I will assume that you suggest I remove it :-)
>
> I'll wait to see what others have to say and if they think
> it useful or just clutter and debugging.
I also think it's best removed.
> >> + /* Disabled until we fix BZ #14473 */
> >
> > Add a "." and two spaces as usual here.
>
> Fixed.
I'd also rather this said "bug" rather than "BZ#", to make it easier to
find all the places where tests are disabled because of known bugs (all of
which say "bug" at present).
> > Besides the two issues, this looks fine. I suggest to give others two
> > more days to review this, I would love to see Joseph's comments here.
> > If there are no further comments, I would consider it fine.
I have no further comments.
--
Joseph S. Myers
joseph@codesourcery.com