Re: [PATCH] Add benchmark inputs for inverse trigonometric functions and log

[Andreas Jaeger <aj at suse dot com>]

On 05/21/2013 12:10 PM, Siddhesh Poyarekar wrote:
> Hi,
>
> This patch adds inputs for inverse trigonometric functions, hyperbolic
> trigonometric functions and log.  I could not find slow inputs for
> these, so I guess we'll just have to wait for someone to contribute
> those in future.
>
> OK to commit?
>
> Siddhesh
>
> 	* benchtests/Makefile (bench): Add asin, acos, sinh, cosh,
> 	tanh, asinh, acosh, atanh.
> 	* benchtests/acos-inputs: New file.
> 	* benchtests/acosh-inputs: New file.
> 	* benchtests/asin-inputs: New file.
> 	* benchtests/asinh-inputs: New file.
> 	* benchtests/atanh-inputs: New file.
> 	* benchtests/cosh-inputs: New file.
> 	* benchtests/log-inputs: New file.
> 	* benchtests/sinh-inputs: New file.
> 	* benchtests/tanh-inputs: New file.
>
> diff --git a/benchtests/Makefile b/benchtests/Makefile
> index 913fe4d..6c13c2e 100644
> --- a/benchtests/Makefile
> +++ b/benchtests/Makefile
> @@ -19,7 +19,8 @@
>   # Makefile for benchmark tests.  The only useful target here is `bench`.
>
>   subdir := benchtests
> -bench := exp pow rint sin cos tan atan modf
> +bench := exp pow log rint sin cos tan asin acos atan modf sinh cosh tanh \
> +	 asinh acosh atanh

Looking at your changes for the Makefile, I wonder whether it makes 
sense to sort the entries, so that it's easier to find them. So, sorting 
both bench as well as the single entries by function. If you agree that 
this is beneficial, feel free to sort it before committing.

Otherwise fine,
Thanks,
Andreas




--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126