Re: gcc-4.8 + tree-loop-distribute-patterns breaks glibc-2.18

[Andreas Jaeger <aj at suse dot com>]

On 05/23/2013 07:53 AM, Andreas Jaeger wrote:
> On 05/21/2013 09:20 PM, Adhemerval Zanella wrote:
> > On 21-05-2013 05:52, Andreas Jaeger wrote:
> > > My suggestion was to simplify your patch: remove all the configure
> > > parts and unconditionally include <string.h> (together with a
> > > comment) where needed (as in your patch).
> > >
> > > Wouldn't that work?
> > >
> > > Andreas
> >
> > For the check-localplt case I think it is suffice, but I'm not sure if
> > it will be the
> > case for string algorithms in the loader (I'll check it). I did the
> > configure part
> > mostly to be prepared fr such cases where include <string.h> is not
> > enough.
> >
> > Based on your comments, I propose the following patch to fix the
> > check-localplt issues
> > I observed with GCC 4.8 and GCC trunk on PPC32 and PPC64. I tested
> > with default 4.8
> > from gcc site and also with today gcc trunk on both PPC32 and PCP64.
> >
> > Any comments?
>
> This patch looks fine to me,
> Andreas

Just found these two comments:
http://sourceware.org/ml/libc-alpha/2013-04/msg00209.html
http://sourceware.org/ml/libc-alpha/2013-04/msg00133.html

So, there was in the past no consensus on this kind of patch ;(.

Adhemerval, I would be fine with this patch but I'm not 
objecting/blocking any other one,

Andreas
--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126