This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [SPATCH] Add space after function call.
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 31 May 2013 20:21:19 +0200
- Subject: Re: [SPATCH] Add space after function call.
- References: <20130530104617 dot GA14219 at domone dot kolej dot mff dot cuni dot cz> <Pine dot LNX dot 4 dot 64 dot 1305311650090 dot 9860 at digraph dot polyomino dot org dot uk>
On Fri, May 31, 2013 at 05:02:10PM +0000, Joseph S. Myers wrote:
> For cases such as GLRO, GL and ElfW, where the macro call is more like a
> variable or type name than a function call and almost universal practice
> is not to have the space, I think additions of the spaces would need
> discussing separately. (There might be other such cases as well.)
>
As macros are generaly uppercase we could remove space when uppercase.
>
> I suspect that quite a few changes would run into the badly formatted
> lines also having trailing whitespace on them and so being rejected by the
> commit hooks. While you could remove trailing whitespace as part of the
> patch generation, it may be better to do an initial patch that cleans up
> all the whitespace issues - trailing whitespace, blank lines at end of
> file, spaces before TABs - once and for all (with the usual caveats about
> avoiding changing generated files or files imported from elsewhere, as
> described at <http://sourceware.org/glibc/wiki/Regeneration>).
>
This is relatively easy to add.