This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [SPATCH] Add space after function call.


On Fri, May 31, 2013 at 05:02:10PM +0000, Joseph S. Myers wrote:
> For cases such as GLRO, GL and ElfW, where the macro call is more like a 
> variable or type name than a function call and almost universal practice 
> is not to have the space, I think additions of the spaces would need 
> discussing separately.  (There might be other such cases as well.)
> 
As macros are generaly uppercase we could remove space when uppercase.
> 
> I suspect that quite a few changes would run into the badly formatted 
> lines also having trailing whitespace on them and so being rejected by the 
> commit hooks.  While you could remove trailing whitespace as part of the 
> patch generation, it may be better to do an initial patch that cleans up 
> all the whitespace issues - trailing whitespace, blank lines at end of 
> file, spaces before TABs - once and for all (with the usual caveats about 
> avoiding changing generated files or files imported from elsewhere, as 
> described at <http://sourceware.org/glibc/wiki/Regeneration>).
> 
This is relatively easy to add.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]