This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PowerPC: Reserve TCB space for EBB framework
- From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Date: Tue, 04 Jun 2013 00:42:10 -0300
- Subject: Re: PowerPC: Reserve TCB space for EBB framework
- References: <51AE58C1 dot 7030503 at linux dot vnet dot ibm dot com> <CAAKybw9T3E=puCXn5meEO6V3Et-0j3c5MBQvO1fH6rceTat80g at mail dot gmail dot com>
On 06/04/2013 07:01 PM, Ryan S. Arnold wrote:
> On Tue, Jun 4, 2013 at 4:14 PM, Adhemerval Zanella
> <azanella@linux.vnet.ibm.com> wrote:
>> diff --git a/nptl/sysdeps/powerpc/tls.h b/nptl/sysdeps/powerpc/tls.h
>> index 46dac9e..56198fa 100644
>> --- a/nptl/sysdeps/powerpc/tls.h
>> +++ b/nptl/sysdeps/powerpc/tls.h
>> @@ -64,6 +64,10 @@ typedef struct
>> uintptr_t pointer_guard;
>> uintptr_t stack_guard;
>> dtv_t *dtv;
>> + uintptr_t thread_handler;
> This is a bit non-descriptive. I'd prefer something like ebb_handler,
> which describes the intended usage.
>
>> + uintptr_t context_pointer;
> Likewise ebb_context_pointer.
>
>> + uintptr_t reserved1;
>> + uintptr_t reserved2;
> Should these be marked ebb_ as well? ebb_reserved1 and ebb_reserved2?
I'll change it, but since their usage is only internal I was really
worried about naming. We can change it later with EBB functional patches.