This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/6 v2] Add fmemopen compatibility version.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: OndÅej BÃlka <neleai at seznam dot cz>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 5 Jun 2013 12:34:03 +0000
- Subject: Re: [PATCH 2/6 v2] Add fmemopen compatibility version.
- References: <1370099488-13916-1-git-send-email-neleai at seznam dot cz> <1370099488-13916-3-git-send-email-neleai at seznam dot cz> <Pine dot LNX dot 4 dot 64 dot 1306031546390 dot 18596 at digraph dot polyomino dot org dot uk> <20130605102140 dot GC8824 at domone dot kolej dot mff dot cuni dot cz>
On Wed, 5 Jun 2013, Ondrej Bilka wrote:
> > You may also need a versioned_symbol call to give the new fmemopen the
> > right version; I'm not sure if that's required or if listing the new
> > version in the Versions file will be sufficient.
> >
> How is this done?
There are plenty of existing uses of versioned_symbol available as
examples.
> Here is v2.
>
> * libio/Makefile (routines): Add oldfmemopen.
> * libio/Versions (libc): Add compatibility symbol.
> * libio/oldfmemopen.c: New file.
This patch is either incorrect or incomplete. If it works, it can't have
passed testing, because all the ABI test baselines should be updated by a
patch adding new symbol versions and this patch does not update them. If
it passed ABI testing, then it is broken and fails to add the new symbol
version.
You need in such a case to make sure manually that both versions are
exported, the old one as a compat symbol and the new one not as a compat
symbol, with each pointing to the correct function implementation, in
addition to the usual validation with the testsuite.
--
Joseph S. Myers
joseph@codesourcery.com