This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove hidden_def for __gettimeofday for x86_64
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 12 Jun 2013 09:58:33 +0530
- Subject: Re: [PATCH] Remove hidden_def for __gettimeofday for x86_64
- References: <20130611131855 dot GJ8010 at spoyarek dot pnq dot redhat dot com> <Pine dot LNX dot 4 dot 64 dot 1306111924160 dot 897 at digraph dot polyomino dot org dot uk>
On Tue, Jun 11, 2013 at 07:26:22PM +0000, Joseph S. Myers wrote:
> On Tue, 11 Jun 2013, Siddhesh Poyarekar wrote:
>
> > * include/sys/time.h: Move file...
> > * sysdeps/generic/sys/time.h: ... here.
>
> That seems wrong. include/ are internal headers, whereas sys/ headers
> from sysdeps directories will get installed (and I don't know whether the
> sysdeps version or the time/ version would take precedence). Did you
> check the correct header still got installed after your patch? If you
> need a system-specific internal header wrapping a public header, use an
> include/ subdirectory of the sysdeps directory.
Thanks, I didn't catch that. I also realized that the gcc
tree-loop-distribute-patterns may be causing some pain here as well.
I'll investigate that too before posting an updated version.
Siddhesh