This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix unary operator spacing.
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 12 Jun 2013 10:20:08 +0200
- Subject: Re: [PATCH] Fix unary operator spacing.
- References: <20130610115907 dot GA9457 at domone> <Pine dot LNX dot 4 dot 64 dot 1306101230520 dot 5269 at digraph dot polyomino dot org dot uk> <20130610133110 dot GA27104 at domone> <Pine dot LNX dot 4 dot 64 dot 1306101351100 dot 15706 at digraph dot polyomino dot org dot uk>
On Mon, Jun 10, 2013 at 01:56:32PM +0000, Joseph S. Myers wrote:
> On Mon, 10 Jun 2013, Ondrej Bilka wrote:
>
> > On Mon, Jun 10, 2013 at 12:32:26PM +0000, Joseph S. Myers wrote:
> > > On Mon, 10 Jun 2013, Ondrej Bilka wrote:
> > >
> > > > Continuing code cleanup now we focus on !~ followed by space.
> > > > Patch is at
> > > > http://www.kam.mff.cuni.cz/~ondra/fix_unary_operator_spacing.patch
> > >
> > > Does not appear to exist.
> > There was extra www there.
> >
> > http://kam.mff.cuni.cz/~ondra/fix_unary_operator_spacing.patch
>
> A quick look over parts of the patch shows cases where this moves the open
> parenthesis of a function or macro call, that continues to a subsequent
> line, to the left, so requiring reindentation of subsequent lines of that
> call. In such cases, please either include the required reindentation in
> the patch (possibly done by a manual editing stage after the initial
> automatic changes), or else exclude such cases and just fix easy cases in
> the automatically generated patch, leaving the hard cases for later (I
> suggest the latter, since it makes the patch smaller and easier to
> review).
>
Here is patch with unbalanced cases excluded.
http://kam.mff.cuni.cz/~ondra/fix_unary_operator_spacing_simple.patch
* argp/argp-fmtstream.c: Fix unary operator spacing.
* argp/argp-parse.c: Likewise.
* csu/libc-start.c: Likewise.
* debug/pcprofile.c: Likewise.
* debug/test-stpcpy_chk.c: Likewise.
* debug/test-strcpy_chk.c: Likewise.
* dirent/scandirat.c: Likewise.
* elf/dl-deps.c: Likewise.
* elf/dl-error.c: Likewise.
* elf/dl-fini.c: Likewise.
* elf/dl-libc.c: Likewise.
* elf/dl-lookup.c: Likewise.
* elf/dl-minimal.c: Likewise.
* elf/dl-misc.c: Likewise.
* elf/dl-profile.c: Likewise.
* elf/dl-runtime.c: Likewise.
* elf/do-rel.h: Likewise.
* elf/initfirst.c: Likewise.
* elf/ldconfig.c: Likewise.
* elf/nodelete.c: Likewise.
* elf/pldd.c: Likewise.
* elf/setup-vdso.h: Likewise.
* elf/sln.c: Likewise.
* elf/tlsdeschtab.h: Likewise.
* elf/tst-execstack.c: Likewise.
* gmon/gmon.c: Likewise.
* grp/initgroups.c: Likewise.
* hurd/fchroot.c: Likewise.
* hurd/fd-write.c: Likewise.
* hurd/get-host.c: Likewise.
* hurd/hurdexec.c: Likewise.
* hurd/hurdid.c: Likewise.
* hurd/hurdioctl.c: Likewise.
* hurd/hurdkill.c: Likewise.
* hurd/hurdlookup.c: Likewise.
* hurd/hurdselect.c: Likewise.
* hurd/hurd/signal.h: Likewise.
* hurd/hurd/userlink.h: Likewise.
* hurd/intr-msg.c: Likewise.
* hurd/lookup-retry.c: Likewise.
* hurd/port2fd.c: Likewise.
* hurd/preempt-sig.c: Likewise.
* hurd/seteuids.c: Likewise.
* hurd/set-host.c: Likewise.
* hurd/sigunwind.c: Likewise.
* hurd/thread-cancel.c: Likewise.
* iconv/iconv_charmap.c: Likewise.
* iconv/iconvconfig.c: Likewise.
* iconv/iconv_open.c: Likewise.
* iconv/iconv_prog.c: Likewise.
* iconv/skeleton.c: Likewise.
* include/inline-hashtab.h: Likewise.
* inet/getnameinfo.c: Likewise.
* inet/getnetgrent_r.c: Likewise.
* inet/inet6_option.c: Likewise.
* inet/rcmd.c: Likewise.
* inet/tst-checks.c: Likewise.
* intl/dcigettext.c: Likewise.
* intl/l10nflist.c: Likewise.
* intl/localealias.c: Likewise.
* intl/plural-eval.c: Likewise.
* io/bits/poll2.h: Likewise.
* io/bug-ftw1.c: Likewise.
* io/bug-ftw2.c: Likewise.
* io/tst-fcntl.c: Likewise.
* libio/tst-eof.c: Likewise.
* libio/tst-fopenloc.c: Likewise.
* libio/tst_getwc.c: Likewise.
* libio/tst_putwc.c: Likewise.
* locale/newlocale.c: Likewise.
* locale/programs/ld-address.c: Likewise.
* locale/programs/ld-ctype.c: Likewise.
* locale/programs/ld-identification.c: Likewise.
* locale/programs/ld-measurement.c: Likewise.
* locale/programs/ld-messages.c: Likewise.
* locale/programs/ld-monetary.c: Likewise.
* locale/programs/ld-name.c: Likewise.
* locale/programs/ld-numeric.c: Likewise.
* locale/programs/ld-paper.c: Likewise.
* locale/programs/ld-telephone.c: Likewise.
* locale/programs/ld-time.c: Likewise.
* locale/programs/locale.c: Likewise.
* locale/programs/localedef.c: Likewise.
* locale/programs/locarchive.c: Likewise.
* locale/programs/locfile.c: Likewise.
* login/login.c: Likewise.
* login/openpty.c: Likewise.
* login/utmp_file.c: Likewise.
* mach/lock-intern.h: Likewise.
* mach/msg-destroy.c: Likewise.
* mach/spin-solid.c: Likewise.
* malloc/arena.c: Likewise.
* malloc/memusage.c: Likewise.
* malloc/set-freeres.c: Likewise.
* math/test-misc.c: Likewise.
* misc/error.c: Likewise.
* misc/syslog.c: Likewise.
* nis/nss_compat/compat-initgroups.c: Likewise.
* nis/nss_nisplus/nisplus-publickey.c: Likewise.
* nscd/cache.c: Likewise.
* nscd/grpcache.c: Likewise.
* nscd/hstcache.c: Likewise.
* nscd/initgrcache.c: Likewise.
* nscd/mem.c: Likewise.
* nscd/nscd_netgroup.c: Likewise.
* nscd/pwdcache.c: Likewise.
* nscd/servicescache.c: Likewise.
* nss/digits_dots.c: Likewise.
* nss/getnssent_r.c: Likewise.
* nss/getXXbyYY_r.c: Likewise.
* nss/nss_files/files-alias.c: Likewise.
* nss/nss_files/files-grp.c: Likewise.
* nss/nss_files/files-hosts.c: Likewise.
* nss/nss_files/files-initgroups.c: Likewise.
* nss/nss_files/files-netgrp.c: Likewise.
* nss/nss_files/files-pwd.c: Likewise.
* nss/nss_files/files-sgrp.c: Likewise.
* nss/nss_files/files-spwd.c: Likewise.
* nss/nsswitch.c: Likewise.
* posix/annexc.c: Likewise.
* posix/bug-regex14.c: Likewise.
* posix/bug-regex31.c: Likewise.
* posix/bug-regex6.c: Likewise.
* posix/fnmatch_loop.c: Likewise.
* posix/glob.c: Likewise.
* posix/regex_internal.c: Likewise.
* posix/transbug.c: Likewise.
* posix/tst-cpuset.c: Likewise.
* posix/tst-dir.c: Likewise.
* posix/tst-fnmatch.c: Likewise.
* posix/tst-gnuglob.c: Likewise.
* posix/tst-waitid.c: Likewise.
* posix/wordexp.c: Likewise.
* pwd/fgetpwent_r.c: Likewise.
* shadow/fgetspent_r.c: Likewise.
* stdio-common/_i18n_number.h: Likewise.
* stdio-common/printf_fp.c: Likewise.
* stdio-common/printf_fphex.c: Likewise.
* stdio-common/scanf11.c: Likewise.
* stdio-common/test-fwrite.c: Likewise.
* stdio-common/tst-fseek.c: Likewise.
* stdio-common/tst-sscanf.c: Likewise.
* stdio-common/vfscanf.c: Likewise.
* stdlib/setenv.c: Likewise.
* stdlib/strtod_l.c: Likewise.
* string/argz-insert.c: Likewise.
* string/argz-replace.c: Likewise.
* string/envz.c: Likewise.
* string/strcoll_l.c: Likewise.
* string/strxfrm_l.c: Likewise.
* string/test-memccpy.c: Likewise.
* string/test-memchr.c: Likewise.
* string/test-memcmp.c: Likewise.
* string/test-memcpy.c: Likewise.
* string/test-memmem.c: Likewise.
* string/test-memmove.c: Likewise.
* string/test-memset.c: Likewise.
* string/test-rawmemchr.c: Likewise.
* string/test-strcasecmp.c: Likewise.
* string/test-strcat.c: Likewise.
* string/test-strchr.c: Likewise.
* string/test-strcmp.c: Likewise.
* string/test-strcpy.c: Likewise.
* string/test-strlen.c: Likewise.
* string/test-strncasecmp.c: Likewise.
* string/test-strncat.c: Likewise.
* string/test-strncmp.c: Likewise.
* string/test-strncpy.c: Likewise.
* string/test-strnlen.c: Likewise.
* string/test-strpbrk.c: Likewise.
* string/test-strrchr.c: Likewise.
* string/test-strspn.c: Likewise.
* sunrpc/auth_unix.c: Likewise.
* sunrpc/publickey.c: Likewise.
* sunrpc/svc.c: Likewise.
* sunrpc/tst-xdrmem2.c: Likewise.
* sunrpc/xdr_rec.c: Likewise.
* sysdeps/generic/unwind-dw2-fde.c: Likewise.
* sysdeps/i386/dl-machine.h: Likewise.
* sysdeps/ieee754/dbl-64/e_exp2.c: Likewise.
* sysdeps/ieee754/dbl-64/e_jn.c: Likewise.
* sysdeps/ieee754/flt-32/e_jnf.c: Likewise.
* sysdeps/ieee754/ldbl-128/e_j0l.c: Likewise.
* sysdeps/ieee754/ldbl-128/e_j1l.c: Likewise.
* sysdeps/ieee754/ldbl-128/e_jnl.c: Likewise.
* sysdeps/ieee754/ldbl-128/e_lgammal_r.c: Likewise.
* sysdeps/ieee754/ldbl-128ibm/e_jnl.c: Likewise.
* sysdeps/ieee754/ldbl-96/e_jnl.c: Likewise.
* sysdeps/mach/hurd/accept4.c: Likewise.
* sysdeps/mach/hurd/bind.c: Likewise.
* sysdeps/mach/hurd/brk.c: Likewise.
* sysdeps/mach/hurd/connect.c: Likewise.
* sysdeps/mach/hurd/dl-sysdep.c: Likewise.
* sysdeps/mach/hurd/faccessat.c: Likewise.
* sysdeps/mach/hurd/fexecve.c: Likewise.
* sysdeps/mach/hurd/fork.c: Likewise.
* sysdeps/mach/hurd/group_member.c: Likewise.
* sysdeps/mach/hurd/i386/ioperm.c: Likewise.
* sysdeps/mach/hurd/i386/trampoline.c: Likewise.
* sysdeps/mach/hurd/isatty.c: Likewise.
* sysdeps/mach/hurd/jmp-unwind.c: Likewise.
* sysdeps/mach/hurd/kill.c: Likewise.
* sysdeps/mach/hurd/mmap.c: Likewise.
* sysdeps/mach/hurd/profil.c: Likewise.
* sysdeps/mach/hurd/ptrace.c: Likewise.
* sysdeps/mach/hurd/readlinkat.c: Likewise.
* sysdeps/mach/hurd/readlink.c: Likewise.
* sysdeps/mach/hurd/sendmsg.c: Likewise.
* sysdeps/mach/hurd/sendto.c: Likewise.
* sysdeps/mach/hurd/setgroups.c: Likewise.
* sysdeps/mach/hurd/setitimer.c: Likewise.
* sysdeps/mach/hurd/setpriority.c: Likewise.
* sysdeps/mach/hurd/sigwait.c: Likewise.
* sysdeps/mach/hurd/spawni.c: Likewise.
* sysdeps/mach/hurd/symlinkat.c: Likewise.
* sysdeps/mach/hurd/symlink.c: Likewise.
* sysdeps/mach/hurd/unlinkat.c: Likewise.
* sysdeps/mach/hurd/xmknodat.c: Likewise.
* sysdeps/mach/_strerror.c: Likewise.
* sysdeps/mach/strerror_l.c: Likewise.
* sysdeps/mach/xpg-strerror.c: Likewise.
* sysdeps/posix/fdopendir.c: Likewise.
* sysdeps/posix/fpathconf.c: Likewise.
* sysdeps/posix/pathconf.c: Likewise.
* sysdeps/posix/posix_fallocate64.c: Likewise.
* sysdeps/posix/posix_fallocate.c: Likewise.
* sysdeps/posix/spawni.c: Likewise.
* sysdeps/posix/tempname.c: Likewise.
* sysdeps/posix/ttyname.c: Likewise.
* sysdeps/posix/waitid.c: Likewise.
* sysdeps/powerpc/fpu/fedisblxcpt.c: Likewise.
* sysdeps/powerpc/fpu/feenablxcpt.c: Likewise.
* sysdeps/sparc/sparc64/dl-machine.h: Likewise.
* sysdeps/unix/bsd/telldir.c: Likewise.
* sysdeps/unix/grantpt.c: Likewise.
* sysdeps/unix/sysv/linux/check_native.c: Likewise.
* sysdeps/unix/sysv/linux/check_pf.c: Likewise.
* sysdeps/unix/sysv/linux/fstatfs64.c: Likewise.
* sysdeps/unix/sysv/linux/getipv4sourcefilter.c: Likewise.
* sysdeps/unix/sysv/linux/getsourcefilter.c: Likewise.
* sysdeps/unix/sysv/linux/i386/posix_fallocate64.c: Likewise.
* sysdeps/unix/sysv/linux/i386/posix_fallocate.c: Likewise.
* sysdeps/unix/sysv/linux/i386/scandir64.c: Likewise.
* sysdeps/unix/sysv/linux/i386/sysconf.c: Likewise.
* sysdeps/unix/sysv/linux/ifaddrs.c: Likewise.
* sysdeps/unix/sysv/linux/internal_statvfs.c: Likewise.
* sysdeps/unix/sysv/linux/posix_fallocate64.c: Likewise.
* sysdeps/unix/sysv/linux/posix_fallocate.c: Likewise.
* sysdeps/unix/sysv/linux/ptsname.c: Likewise.
* sysdeps/unix/sysv/linux/readonly-area.c: Likewise.
* sysdeps/unix/sysv/linux/setipv4sourcefilter.c: Likewise.
* sysdeps/unix/sysv/linux/setsourcefilter.c: Likewise.
* sysdeps/unix/sysv/linux/sigwait.c: Likewise.
* sysdeps/unix/sysv/linux/statfs64.c: Likewise.
* sysdeps/unix/sysv/linux/ttyname.c: Likewise.
* sysdeps/unix/sysv/linux/wordsize-64/posix_fallocate.c: Likewise.
* sysdeps/x86_64/cacheinfo.c: Likewise.
* sysdeps/x86_64/dl-machine.h: Likewise.
* sysdeps/x86_64/fpu/fesetenv.c: Likewise.
* sysdeps/x86_64/fpu/fesetround.c: Likewise.
* sysdeps/x86_64/tlsdesc.c: Likewise.
* termios/tcgetsid.c: Likewise.
* time/alt_digit.c: Likewise.
* time/difftime.c: Likewise.
* time/era.c: Likewise.
* time/mktime.c: Likewise.
* time/strptime_l.c: Likewise.
* time/tst-posixtz.c: Likewise.
* time/tzfile.c: Likewise.
* time/tzset.c: Likewise.
localedata/Changelog:
* show-ucs-data.c: Fix unary operator spacing.
* tests/test6.c: Likewise.
* tst-digits.c: Likewise.
* tst-langinfo.c: Likewise.
nptl/Changelog:
* cond-perf.c: Fix unary operator spacing.
* perf.c: Likewise.
* pthread_cond_wait.c: Likewise.
* pthread_create.c: Likewise.
* pthread_getattr_np.c: Likewise.
* pthread_mutexattr_getprioceiling.c: Likewise.
* pthread_mutex_init.c: Likewise.
* pthread_mutex_lock.c: Likewise.
* pthread_mutex_setprioceiling.c: Likewise.
* pthread_mutex_timedlock.c: Likewise.
* pthread_mutex_unlock.c: Likewise.
* sockperf.c: Likewise.
* sysdeps/pthread/timer_delete.c: Likewise.
* sysdeps/pthread/timer_getoverr.c: Likewise.
* sysdeps/pthread/timer_routines.c: Likewise.
* sysdeps/pthread/timer_settime.c: Likewise.
* sysdeps/unix/sysv/linux/timer_create.c: Likewise.
* tst-basic4.c: Likewise.
* tst-cond7.c: Likewise.
* tst-exec4.c: Likewise.
* tst-mutex8.c: Likewise.
* tst-mutex9.c: Likewise.
* tst-signal5.c: Likewise.
nptl_db/Changelog:
* td_ta_clear_event.c: Fix unary operator spacing.
* td_ta_enable_stats.c: Likewise.
* td_ta_event_addr.c: Likewise.
* td_ta_event_getmsg.c: Likewise.
* td_ta_get_nthreads.c: Likewise.
* td_ta_get_ph.c: Likewise.
* td_ta_get_stats.c: Likewise.
* td_ta_map_id2thr.c: Likewise.
* td_ta_map_lwp2thr.c: Likewise.
* td_ta_reset_stats.c: Likewise.
* td_ta_setconcurrency.c: Likewise.
* td_ta_set_event.c: Likewise.
* td_ta_thr_iter.c: Likewise.
* td_ta_tsd_iter.c: Likewise.