This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fixes tree-loop-distribute-patterns issues
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: "Carlos O'Donell" <carlos at redhat dot com>, "GNU C. Library" <libc-alpha at sourceware dot org>, Siddhesh Poyarekar <siddhesh at redhat dot com>
- Date: Thu, 20 Jun 2013 10:58:32 -0700 (PDT)
- Subject: Re: [PATCH] Fixes tree-loop-distribute-patterns issues
- References: <51C0AFB7 dot 1060009 at linux dot vnet dot ibm dot com> <20130618205608 dot 9CCE22C0AC at topped-with-meat dot com> <51C1BFE9 dot 4070805 at linux dot vnet dot ibm dot com> <51C1CEFC dot 9000100 at redhat dot com> <51C1FE4C dot 3020400 at linux dot vnet dot ibm dot com> <20130619221130 dot 7B91A2C10E at topped-with-meat dot com> <51C31177 dot 90303 at linux dot vnet dot ibm dot com>
Thanks, that is much closer.
Though it's a "known fact" that there are no compilers that accept
-fno-tree-loop-distribute-patterns on the command line but do not accept
__attribute__ ((optimize ("-fno-tree-loop-distribute-patterns"))), it is
strange and unusual to have the configure test check for command-line
support when the actual thing we need to use is attribute support. In a
less severe way, this too violates the principle of empirical tests in
configure checks. Please change the configure check so that it tests the
syntax that we actually use.
The libc-symbols.h definition also needs clear comments about its purpose
and appropriate uses, as I mentioned before.
I think this patch will be fine with those two improvements.
Further, I think we should apply the macro to every simple_* function in
every string/ test (not just the ones we know today have an issue). But
that could be a separate follow-up patch if you prefer.
Thanks,
Roland