This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fixes tree-loop-distribute-patterns issues
- From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Date: Thu, 20 Jun 2013 21:44:44 -0300
- Subject: Re: [PATCH] Fixes tree-loop-distribute-patterns issues
- References: <51C0AFB7 dot 1060009 at linux dot vnet dot ibm dot com> <20130618205608 dot 9CCE22C0AC at topped-with-meat dot com> <51C1BFE9 dot 4070805 at linux dot vnet dot ibm dot com> <51C1CEFC dot 9000100 at redhat dot com> <51C1FE4C dot 3020400 at linux dot vnet dot ibm dot com> <20130619221130 dot 7B91A2C10E at topped-with-meat dot com> <51C31177 dot 90303 at linux dot vnet dot ibm dot com> <20130620175832 dot 0E6FA2C133 at topped-with-meat dot com> <51C34955 dot 1080708 at linux dot vnet dot ibm dot com> <20130620183414 dot ADAEB2C133 at topped-with-meat dot com>
On 20-06-2013 15:34, Roland McGrath wrote:
>> +/* Add the compiler optimization to inhibit loop transformation to library
>> + calls. This is used to avoid recursive calls in memset and memmove
>> + default implementations. */
> This feels a little awkward, but it is adequate.
> But, two spaces between sentences!
>
> With that trivial addition of one ' ', this patch is now fine.
> Of course you need not post it again with the ' ' added (nor if
> you reword the comment in other ways); just commit it.
>
> Thanks for your work on this and for your patience with my picayune reviews.
>
>
> Thanks,
> Roland
>
No worries, your reviews and Carlos' one were very helpful. Pushed as
85c2e6110c9a01ec817c30f1b7e20549d7229987.