This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: TSX lock elision for glibc v12
- From: Torvald Riegel <triegel at redhat dot com>
- To: Andi Kleen <andi at firstfloor dot org>
- Cc: Rich Felker <dalias at aerifal dot cx>, libc-alpha at sourceware dot org, "Carlos O'Donell" <carlos at redhat dot com>, Roland McGrath <roland at hack dot frob dot com>
- Date: Fri, 21 Jun 2013 18:53:49 +0200
- Subject: Re: TSX lock elision for glibc v12
- References: <1371592286-22073-1-git-send-email-andi at firstfloor dot org> <1371753271 dot 964 dot 2220 dot camel at triegel dot csb> <20130621012328 dot GA29800 at brightrain dot aerifal dot cx> <1371811686 dot 964 dot 4100 dot camel at triegel dot csb> <1371823366 dot 964 dot 4706 dot camel at triegel dot csb> <1371824261 dot 964 dot 4757 dot camel at triegel dot csb> <1371826829 dot 964 dot 4905 dot camel at triegel dot csb> <20130621160924 dot GN6123 at two dot firstfloor dot org>
On Fri, 2013-06-21 at 18:09 +0200, Andi Kleen wrote:
> > - PTHREAD_MUTEX_KIND_MASK_NP = 3,
> > + PTHREAD_MUTEX_KIND_MASK_NP = 7,
> > + /* New internal alias for PTHREAD_MUTEX_DEFAULT-like mutexes. */
> > + PTHREAD_MUTEX_DEFAULT_INT_NP = PTHREAD_MUTEX_TIMED_NP,
> > + /* New internal type used for PTHREAD_MUTEX_NORMAL-like mutexes. */
> > + PTHREAD_MUTEX_NORMAL_INT_NP = 5,
>
> Why internal? It should be external right?
I don't want to change or expose anything externally if I don't have to.
This will make it easier for us to just enable elision without risking
to have to maintain other interfaces, break ABIs, etc.
> Internally the existing don't elide flag should be good enough.
This patch (also see the updated one please) is intended to sit below
any elision patches. I think that's the right approach because it fixes
an obstacle in our current way of representing types, and could be
useful for stuff besides a particular lock elision implementation.