This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix soft-fp shadowing between __FP_FRAC_ADD_3 and _FP_MUL_MEAT_2_wide_3mul (bug 15667)
- From: David Miller <davem at davemloft dot net>
- To: joseph at codesourcery dot com
- Cc: libc-alpha at sourceware dot org
- Date: Sat, 22 Jun 2013 11:58:01 -0700 (PDT)
- Subject: Re: Fix soft-fp shadowing between __FP_FRAC_ADD_3 and _FP_MUL_MEAT_2_wide_3mul (bug 15667)
- References: <Pine dot LNX dot 4 dot 64 dot 1306221208430 dot 10964 at digraph dot polyomino dot org dot uk>
From: "Joseph S. Myers" <joseph@codesourcery.com>
Date: Sat, 22 Jun 2013 12:10:59 +0000
> This patch fixes bug 15667, soft-fp variables _c1 and _c2 in
> __FP_FRAC_ADD_3 shadowing those in _FP_MUL_MEAT_2_wide_3mul.
>
> I renamed the variables to include the full macro name. Probably this
> should be done for all variables defined internally by any soft-fp
> macro (maybe using abbreviated versions of the macro names if the full
> names are too long and make the code too cumbersome); this patch
> simply addresses the particular case where shadowing actually occurs
> and shows up as test failures with the soft-fp fma patch I'll send
> separately after some further testing.
>
> Tested on MIPS64 in conjunction with that fma patch.
Looks good, thanks for fixing this Joseph.