This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 5/5][v2][BZ #15022] Remove dead DL_DST_REQ_STATIC code
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 27 Jun 2013 14:31:28 -0700 (PDT)
- Subject: Re: [PATCH 5/5][v2][BZ #15022] Remove dead DL_DST_REQ_STATIC code
- References: <alpine dot DEB dot 1 dot 10 dot 1301152056590 dot 4834 at tp dot orcam dot me dot uk> <20130116215545 dot 7A37A2C0B0 at topped-with-meat dot com> <alpine dot DEB dot 1 dot 10 dot 1301240655220 dot 4834 at tp dot orcam dot me dot uk> <20130531200059 dot C94C02C077 at topped-with-meat dot com> <alpine dot DEB dot 1 dot 10 dot 1306140202520 dot 16287 at tp dot orcam dot me dot uk> <20130619234127 dot EF2602C0B4 at topped-with-meat dot com> <alpine dot DEB dot 1 dot 10 dot 1306211841570 dot 16287 at tp dot orcam dot me dot uk>
> I can see in the sources that _dl_init_paths is only called from two
> sites -- _dl_non_dynamic_init, that clearly doesn't apply here, and
> dl_main. In the latter case the call is only made after the main map has
> already been initialised. So perhaps that "if (l != NULL)" quoted above
> can really be "assert (l != NULL)"? I'll send a patch proposal if so.
I think you're right. You don't even need the assert, since it's accessed
immediately and will have a straightforward crash if it's ever null.