This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Test for mprotect failure in dl-load.c (bug 12492)
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 28 Jun 2013 14:22:10 -0700 (PDT)
- Subject: Re: Test for mprotect failure in dl-load.c (bug 12492)
- References: <Pine dot LNX dot 4 dot 64 dot 1306281723190 dot 27363 at digraph dot polyomino dot org dot uk>
That's fine. My first inclination was to say the message should say what
it was doing mprotect for. OTOH, you're reusing an existing message (also
vague, though previously unambiguous if you looked in the source) so no new
translation is needed. There remain three mprotect calls in dl-load.c that
don't check for errors. But since those are reducing access rather than
increasing it, perhaps that's OK.