This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PowerPC floating point little-endian [2 of 15]
- From: Andreas Jaeger <aj at suse dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 10 Jul 2013 07:50:07 +0200
- Subject: Re: PowerPC floating point little-endian [2 of 15]
- References: <20130710012435 dot GN2602 at bubble dot grove dot modra dot org> <20130710012520 dot GO2602 at bubble dot grove dot modra dot org>
On 07/10/2013 03:25 AM, Alan Modra wrote:
> This patch replaces occurrences of GET_LDOUBLE_* and SET_LDOUBLE_*
> macros, and union ieee854_long_double_shape_type in ldbl-128ibm/,
> and a stray one in the 32-bit fpu support. These files have no
> significant changes apart from rewriting the long double bit access.
>
> In the following I make use of the fact that casting a long double to
> double retrieves the high double, rather than calling ldbl_unpack
> everywhere.
I don't like this specific change, it's not obvious for the reader. I
suggest to introduce a documented macro that does the casting and use
that one.
> I generally resisted the urge to make formatting fixes in this series
> of patches, thinking that would be better as a separate patch.
Indeed.
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126