This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/9] Fix typos.


On 19/08/13 08:09, OndÅej BÃlka wrote:
> On Sun, Aug 18, 2013 at 08:15:24PM +0000, Joseph S. Myers wrote:
>> I stopped commenting here.  For any subsequent revisions, in addition to 
>> the points I identified above, please keep patches down to at most 1000 
>> lines for convenience of review, and wait until consensus has been reached 
>> on a single posted patch before sending any subsequent patches (also of at 
>> most 1000 lines).
>>
> I split patches to 1000 lines, here is first one.
> 

<snip>

This is the only one that I think needs fixed as there was more than
just a typo going on there.

> diff --git a/iconv/skeleton.c b/iconv/skeleton.c
> index 45beb06..6997e05 100644
> --- a/iconv/skeleton.c
> +++ b/iconv/skeleton.c
> @@ -514,7 +514,7 @@ FUNCTION_NAME (struct __gconv_step *step, struct __gconv_step_data *data,
>        size_t *lirreversiblep = irreversible ? &lirreversible : NULL;
>  
>        /* The following assumes that encodings, which have a variable length
> -	 what might unalign a buffer even though it is a aligned in the
> +	 what might unalign a buffer even though it is an aligned in the
>  	 beginning, either don't have the minimal number of bytes as a divisor
>  	 of the maximum length or have a minimum length of 1.  This is true
>  	 for all known and supported encodings.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]