This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: LC_ADDRESS and other locale updates [was: sr_ME locale country_isbn and int_prefix fix]
- From: Chris Leonard <cjlhomeaddress at gmail dot com>
- To: Jakub Bogusz <qboosh at pld-linux dot org>
- Cc: "Carlos O'Donell" <carlos at redhat dot com>, libc-alpha <libc-alpha at sourceware dot org>, libc-locales at sourceware dot org
- Date: Mon, 26 Aug 2013 18:35:05 -0400
- Subject: Re: LC_ADDRESS and other locale updates [was: sr_ME locale country_isbn and int_prefix fix]
- Authentication-results: sourceware.org; auth=none
- References: <20130519152227 dot GA20733 at stranger dot qboosh dot pl> <CAHdAataN0GXw5yXxrAR_J+eVckFiM0TDSmKsiaStq7yJ-mj=-w at mail dot gmail dot com> <519D893F dot 70901 at redhat dot com> <20130606081419 dot GA7652 at mail> <51B09452 dot 8040009 at redhat dot com> <20130826185611 dot GA11561 at stranger dot qboosh dot pl> <CAHdAata7caee2Yj7qEJbExVh1L1nn630Ji6YhUWCxRvjYH9WOQ at mail dot gmail dot com>
In addition, it would really help the review of these patches if you
commented the country_car entries to contain the non-encoded value
e.g.
> +% ETH
> +country_car "<U0045><U0054><U0048>"
It would make it much easier to confirm these patches against
http://en.wikipedia.org/wiki/List_of_international_license_plate_codes
cjl
On Mon, Aug 26, 2013 at 5:25 PM, Chris Leonard <cjlhomeaddress@gmail.com> wrote:
> I looked at your first patch
>
> Fill in country_{car,isbn} for aa_ET.
>
> --- libc.orig/localedata/locales/aa_ET 2003-11-04 05:53:19.000000000 +0100
> +++ libc/localedata/locales/aa_ET 2004-11-10 02:36:38.000000000 +0100
> @@ -109,8 +109,8 @@
> country_ab2 "<U0045><U0054>"
> country_ab3 "<U0045><U0054><U0048>"
> country_num 231 % 210 found in at least one ISO 3166 doc
> -% country_car unknown
> -% country_isbn unknown, Need ISO 2108
> +country_car "<U0045><U0054><U0048>"
> +country_isbn "<U0039><U0039><U0039><U0034><U0034>"
> lang_name "<U0051><U0061><U0066><U0061><U0072>"
> lang_ab "<U0061><U0061>"
> lang_term "<U0061><U0061><U0072>"
>
>
> I am not 100% sure, but I was under the impression from looking at
> other locales that country_isbn was a simple numeric value and not
> quoted and converted into Unicode points.
>
> Am I correct in this?
>
> cjl
>
>
> On Mon, Aug 26, 2013 at 2:56 PM, Jakub Bogusz <qboosh@pld-linux.org> wrote:
>> On Thu, Jun 06, 2013 at 09:53:22AM -0400, Carlos O'Donell wrote:
>>> On 06/06/2013 04:14 AM, Jakub Bogusz wrote:
>>> > On Wed, May 22, 2013 at 11:13:03PM -0400, Carlos O'Donell wrote:
>>> >> On 05/22/2013 10:41 PM, Chris Leonard wrote:
>>> >>> This will probably be ignored on libc-locales, forwarding to
>>> >>> libc-alpha for consideration.
>>> >>
>>> >> Chris,
>>> >>
>>> >> I saw this on libc-locales, but I'm up to my ears in other things.
>>> >>
>>> >> Are you able to review it and check it in? :-)
>>> >>
>>> >> If we are going to grow as a community we need to delegate work.
>>> >
>>> > Any progress on this patch?
>>>
>>> Not yet.
>>>
>>> Added it to the pending review list:
>>> http://sourceware.org/glibc/wiki/Pending%20Reviews
>>>
>>> > There probably should be also Latin version of sr_ME locale, as
>>> > Latin is widely used in Montenegro (when I visited this country last
>>> > year, it appeared to me that Latin is far more common than Cyrillic,
>>> > but I don't have any official evidence for it).
>>> >
>>> > BTW: In PLD we have many country_car, country_isbn and similar fixes
>>> > for other glibc locales. I could isolate some patches - what is the
>>> > preferred way: one patch will all changes, many individual patches for
>>> > each locale, or some blocks of them?
>>>
>>> Many individual patches for each locale is the easiest way to review them.
>>
>> I started the work to split the big patch, verify and update each change
>> (few parts required it).
>> Parts already processed can be seen at:
>> http://qboosh.pl/glibc-locale-fixes/
>> (glibc-locale_fixes.patch contains the remaining, unverified parts)
>>
>>
>> Regards,
>>
>> --
>> Jakub Bogusz http://qboosh.pl/