This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH,HURD] Recognize GNU/Hurd-specific binaries

From: Thomas Schwinge <thomas at codesourcery dot com>
To: Roland McGrath <roland at hack dot frob dot com>
Cc: <bug-hurd at gnu dot org>, <libc-alpha at sourceware dot org>, Samuel Thibault <samuel dot thibault at gnu dot org>
Date: Thu, 29 Aug 2013 12:32:37 +0200
Subject: Re: [PATCH,HURD] Recognize GNU/Hurd-specific binaries
Authentication-results: sourceware.org; auth=none
References: <20110619130724 dot GV6349 at const dot famille dot thibault dot fr> <20110619174812 dot E401B2C131 at topped-with-meat dot com> <20110619181007 dot GY27884 at const dot famille dot thibault dot fr> <20110619180438 dot C7CFF2C0F1 at topped-with-meat dot com> <20110619182247 dot GZ27884 at const dot famille dot thibault dot fr> <20110619184620 dot 6E7732C0E4 at topped-with-meat dot com> <20110703141939 dot GD11935 at const dot famille dot thibault dot fr> <87bo7xo1ay dot fsf at kepler dot schwinge dot homeip dot net> <20130529220140 dot 4761E2C079 at topped-with-meat dot com>

Hi!

On Wed, 29 May 2013 15:01:40 -0700 (PDT), Roland McGrath <roland@hack.frob.com> wrote:
> > First, my "usual" cleanup patch:
> > 
> > 	* sysdeps/unix/sysv/linux/ldsodefs.h (VALID_ELF_OSABI)
> > 	(VALID_ELF_ABIVERSION, MORE_ELF_HEADER_DATA): Use ELFOSABI_GNU
> > 	instead of ELFOSABI_LINUX.
> > 
> > ports/ChangeLog.arm
> > 	* sysdeps/unix/sysv/linux/arm/ldsodefs.h (VALID_ELF_OSABI)
> > 	(MORE_ELF_HEADER_DATA): Use ELFOSABI_GNU instead of ELFOSABI_LINUX.
> > 
> > ports/ChangeLog.mips
> > 	* sysdeps/unix/sysv/linux/mips/ldsodefs.h (VALID_ELF_ABIVERSION):
> > 	Use ELFOSABI_GNU instead of ELFOSABI_LINUX.
> 
> This is fine.

Pushed as commit c54290cf086940e3859b236d0fb880bacab2288b.


> > I suggest we instead implement this in sysdeps/gnu/ldsodefs.h, as this is
> > a common GNU thing.
> 
> That is a good thing to do.
> 
> > Tested on x86 and x86_64 GNU/Linux, and x86 GNU/Hurd; glibc testsuite as
> > well as manually as follows:
> 
> Verify on x86_64-linux-gnu that the change has no effect whatsoever on the
> compiled code.

Had done this back then.

> > 	* sysdeps/unix/sysv/linux/ldsodefs.h (VALID_ELF_HEADER)
> > 	(VALID_ELF_OSABI, VALID_ELF_ABIVERSION, MORE_ELF_HEADER_DATA):
> > 	Move macros to...
> > 	* sysdeps/gnu/ldsodefs.h: ... this new file.
> 
> With that verified, this is fine.

Pushed as commit d821f07c9e9575b47df87cc38f26c31e09b3ce0d.


GrÃÃe,
 Thomas

Attachment: pgpLiTTOPw8nD.pgp
Description: PGP signature

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]