This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add AARCH64 relocation constants to elf/elf.h
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Petr Machata <pmachata at redhat dot com>
- Cc: libc-alpha at sourceware dot org, Marcus Shawcroft <marcus dot shawcroft at linaro dot org>
- Date: Tue, 03 Sep 2013 16:11:09 -0400
- Subject: Re: [PATCH] Add AARCH64 relocation constants to elf/elf.h
- Authentication-results: sourceware.org; auth=none
- References: <m2ppswdsao dot fsf at redhat dot com> <20130829232144 dot D38D12C072 at topped-with-meat dot com> <m2hae8doki dot fsf at redhat dot com> <5220DBDC dot 4040806 at redhat dot com> <m21u57egd8 dot fsf at redhat dot com>
On 09/02/2013 05:13 AM, Petr Machata wrote:
> "Carlos O'Donell" <carlos@redhat.com> writes:
>
>> Your patch also does some whitespace changes that should not be in the same
>> patch as one that adds or renames new constants.
>
> I thought it was a regular practice, to fix coding style of code that
> you touch. But I can drop the whitespace adjustments if that's the
> preference.
I never find it appropriate to mix whitespace and code changes unless you're
rewriting the function.
For a change like this which might get backported by distributions it should
be as minimal as possible.
Cheers,
Carlos.