This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] sunrpc/rpc/types.h: Fix OS X build problem.


On Thursday 05 September 2013 09:39:00 Jia Liu wrote:
> Is this code looks OK?
> 
> #if defined ( __APPLE_CC__ ) || defined( __FreeBSD__ )
> # define __u_char_defined
> #endif
> 
> And, Mike, how do you think?

i really wish we didn't have to do this, but the rpc code base is all kinds of 
ugly, and i don't think we really care about throwing more poop onto that 
pile.  so i wouldn't say no to this sort of change.

note: your style is off (incorrect spacing at the start of the apple symbol), 
and you'll have to send a proper patch.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]