This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 4/6] Do not call _xend if no transaction is active.
- From: Torvald Riegel <triegel at redhat dot com>
- To: libc-alpha at sourceware dot org
- Date: Wed, 11 Sep 2013 15:33:36 +0200
- Subject: Re: [PATCH 4/6] Do not call _xend if no transaction is active.
- Authentication-results: sourceware.org; auth=none
- References: <20130902075228 dot GA4792 at linux dot vnet dot ibm dot com> <20130902080450 dot GD4997 at linux dot vnet dot ibm dot com>
On Mon, 2013-09-02 at 10:04 +0200, Dominik Vogt wrote:
> - _xend();
> + if (_xtest () != 0)
> + _xend ();
>
I disagree with this change (see my other email for details). If we add
such a change in the future because we see that lots of people write
buggy programs (and they incorrectly blame glibc for it), then at the
very least we should fail visibly here, not silent. That is, this
should have an else branch that does something like we do for
error-checking mutexes.