This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #15533] Avoid unnecessary slowdown from profiling with audit
- From: Alexander Monakov <amonakov at ispras dot ru>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: Ondřej Bílka <neleai at seznam dot cz>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 26 Sep 2013 01:13:14 +0400 (MSK)
- Subject: Re: [PATCH][BZ #15533] Avoid unnecessary slowdown from profiling with audit
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LNX dot 2 dot 00 dot 1305250406320 dot 23866 at monopod dot intra dot ispras dot ru> <alpine dot LNX dot 2 dot 00 dot 1308201645010 dot 2626 at monopod dot intra dot ispras dot ru> <20130908193936 dot GF27001 at domone dot kolej dot mff dot cuni dot cz> <20130925181103 dot GA8322 at domone dot podge> <20130925200318 dot 4C4692C07C at topped-with-meat dot com>
On Wed, 25 Sep 2013, Roland McGrath wrote:
> I don't like the O(n) check on every _dl_relocate_object.
'n' here is the number of loaded audit libraries, which is zero in normal use,
and is very unlikely to exceed one as far as I can imagine.
The other audit callbacks are not invoked repeatedly over the process'
lifetime, and correspond to places where the dynamic linker has to do
work anyhow. I wouldn't call optimizing those loops worthwhile.
In my eyes your arguments against the patch look like the proverbial "making
the perfect the enemy of the good". I don't volunteer to implement what you
called "a better solution".
Alexander