This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH v1.1][BZ #14029] Acknowledge that fnmatch can fail.
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Allan McRae <allan at archlinux dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Sun, 13 Oct 2013 08:51:22 +0200
- Subject: [PATCH v1.1][BZ #14029] Acknowledge that fnmatch can fail.
- Authentication-results: sourceware.org; auth=none
- References: <20131013062240 dot GA14374 at domone dot podge> <525A3E17 dot 4050004 at archlinux dot org>
On Sun, Oct 13, 2013 at 04:30:47PM +1000, Allan McRae wrote:
> On 13/10/13 16:22, OndÅej BÃlka wrote:
> > Hi,
> >
> > This corrects factual error in manual as fnmatch can fail when there is
> > not enough memory or when pattern contains illegal sequence.
> >
> > OK to commit this?
> >
> > * manual/pattern.texi: Acknowledge that fnmatch can fail.
> >
> > diff --git a/manual/pattern.texi b/manual/pattern.texi
> > index 1966f3f..55f6682 100644
> > --- a/manual/pattern.texi
> > +++ b/manual/pattern.texi
> > @@ -36,10 +36,8 @@ returns the nonzero value @code{FNM_NOMATCH}. The arguments
> > The argument @var{flags} is a combination of flag bits that alter the
> > details of matching. See below for a list of the defined flags.
> >
> > -In @theglibc{}, @code{fnmatch} cannot experience an ``error''---it
> > -always returns an answer for whether the match succeeds. However, other
> > -implementations of @code{fnmatch} might sometimes report ``errors''.
> > -They would do so by returning nonzero values that are not equal to
> > +The @code{fnmatch} might sometimes report ``errors''.
> > +It do so by returning nonzero values that are not equal to
> > @code{FNM_NOMATCH}.
> > @end deftypefun
>
> That needs gramatical corrections. I suggest:
>
> In @theglibc{}, @code{fnmatch} might sometimes report ``errors'' by
> returning nonzero values that are not equal to @code{FNM_NOMATCH}.
>
> Allan
>
OK, I wanted originaly to say that returning error is generic property
of fnmatch but this is also ok.
* manual/pattern.texi: Acknowledge that fnmatch can fail.
--
diff --git a/manual/pattern.texi b/manual/pattern.texi
index 1966f3f..afd6480 100644
--- a/manual/pattern.texi
+++ b/manual/pattern.texi
@@ -36,11 +36,8 @@ returns the nonzero value @code{FNM_NOMATCH}. The arguments
The argument @var{flags} is a combination of flag bits that alter the
details of matching. See below for a list of the defined flags.
-In @theglibc{}, @code{fnmatch} cannot experience an ``error''---it
-always returns an answer for whether the match succeeds. However, other
-implementations of @code{fnmatch} might sometimes report ``errors''.
-They would do so by returning nonzero values that are not equal to
-@code{FNM_NOMATCH}.
+In @theglibc{}, @code{fnmatch} might sometimes report ``errors'' by
+returning nonzero values that are not equal to @code{FNM_NOMATCH}.
@end deftypefun
These are the available flags for the @var{flags} argument: