This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Async signal safe TLS accesses
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Andrew Hunter <ahh at google dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 22 Oct 2013 21:47:34 +0000
- Subject: Re: [PATCH] Async signal safe TLS accesses
- Authentication-results: sourceware.org; auth=none
- References: <1380830518-16721-1-git-send-email-ahh at google dot com> <1382477766-15770-1-git-send-email-ahh at google dot com>
On Tue, 22 Oct 2013, Andrew Hunter wrote:
> + INTERNAL_SYSCALL_DECL (err);
> +
> + ret = INTERNAL_SYSCALL (rt_sigprocmask, err, 4, SIG_SETMASK, &new, old,
> + _NSIG / 8);
My comment from 3 Oct
<https://sourceware.org/ml/libc-alpha/2013-10/msg00131.html> about
syscalls not being usable directly in elf/, still applies.
> diff --git a/nptl/Makefile b/nptl/Makefile
> index cd601e5..af63800 100644
> --- a/nptl/Makefile
> +++ b/nptl/Makefile
> @@ -1,3 +1,4 @@
> +
> # Copyright (C) 2002-2013 Free Software Foundation, Inc.
> # This file is part of the GNU C Library.
>
My comment about avoiding spurious changes applies here.
> diff --git a/nptl/tst-tls7.c b/nptl/tst-tls7.c
> new file mode 100644
> index 0000000..e146fd0
> --- /dev/null
> +++ b/nptl/tst-tls7.c
> @@ -0,0 +1,103 @@
> +#include <dlfcn.h>
My comment about how new files should start still applies.
--
Joseph S. Myers
joseph@codesourcery.com