This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use __glibc_(un)likely instead __builtin_expect.


On Wed, Oct 23, 2013 at 12:01:31AM +0200, OndÅej BÃlka wrote:
> 
> Hi,
> 
> Now I return to one of todo-list issues which is using glibc-likely/unlikely.
> 
> First comes a easy case which can be expressed as following script.
> 
> cat $1 | sed -e "s/if (__builtin_expect (\(.*\), 0))/if (__glibc_unlikely (\1))/" | sed -e "s/if (__builtin_expect (\(.*\), 1))/if (__glibc_likely (\1))/"
> 

Based on Roland's comment, I did some automated verification of the
patch.  I found the following problems:

1. Changes in whitespace in macro definitions
2. Changes in whitespace in malloc routines

Could you fix these and repost?

Thanks,
Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]