This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 1/2] manual/memory.texi: Bring aligned allocation docs up to date.
- From: Will Newton <will dot newton at linaro dot org>
- To: Ondřej Bílka <neleai at seznam dot cz>
- Cc: libc-alpha <libc-alpha at sourceware dot org>, Patch Tracking <patches at linaro dot org>
- Date: Wed, 20 Nov 2013 13:15:20 +0000
- Subject: Re: [PATCH v2 1/2] manual/memory.texi: Bring aligned allocation docs up to date.
- Authentication-results: sourceware.org; auth=none
- References: <527A6F48 dot 5040803 at linaro dot org> <CANu=DmhEy_u64riYr_FGjXC2sAGW2GNkZtim-OuoTdEJ8Nt2CQ at mail dot gmail dot com> <20131120112536 dot GA26762 at domone dot podge>
On 20 November 2013 11:25, OndÅej BÃlka <neleai@seznam.cz> wrote:
> On Wed, Nov 20, 2013 at 11:08:45AM +0000, Will Newton wrote:
>> On 6 November 2013 16:33, Will Newton <will.newton@linaro.org> wrote:
>> >
>> > The current documentation suggests using memalign and valloc which
>> > are now considered obsolete, so suggest using posix_memalign instead.
>> > Also document the possible error return and errno values for memalign
>> > and posix_memalign and improve documentation of __memalign_hook.
>> >
>> > ChangeLog:
>> >
>> > 2013-11-06 Will Newton <will.newton@linaro.org>
>> >
>> > * manual/memory.texi (Malloc Examples): Clarify default
>> > alignment documentation. Suggest posix_memalign rather
>> > than memalign or valloc.
>> > (Aligned Memory Blocks): Remove suggestion to use memalign
>> > or valloc. Remove obsolete comment about BSD.
>> > Document memalign errno values and mark the function obsolete.
>> > Document posix_memalign returned error codes. Mark valloc
>> > as obsolete. (Hooks for Malloc): __memalign_hook is also
>> > called for posix_memalign and valloc.
>> > (Summary of Malloc): Add posix_memalign to function summary.
>> > __memalign_hook is also called for posix_memalign and valloc.
>> > ---
>> > manual/memory.texi | 61 +++++++++++++++++++++++++++++++++++++++---------------
>> > 1 file changed, 44 insertions(+), 17 deletions(-)
>> >
>> > Changes in v2:
>> > - Fix incorrect errno definitions
>>
>> Ping?
>>
>
> Looks ok,
>
> A minor nit is that if we aim for completeness then pvalloc is currently
> undocumented. It could be added as separate patch or should we keep it
> undocumented?
Yes, I would consider documenting pvalloc in a follow on patch.
--
Will Newton
Toolchain Working Group, Linaro