This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use __glibc_(un)likely instead __builtin_expect.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>, Mike Frysinger <vapier at gentoo dot org>
- Cc: libc-alpha at sourceware dot org, OndÅej BÃlka <neleai at seznam dot cz>, Namhyung Kim <namhyung at gmail dot com>
- Date: Mon, 02 Dec 2013 11:50:48 -0500
- Subject: Re: [PATCH] Use __glibc_(un)likely instead __builtin_expect.
- Authentication-results: sourceware.org; auth=none
- References: <20131022220131 dot GA30971 at domone dot podge> <87vc0g7uvh dot fsf at sejong dot aot dot lge dot com> <20131030131245 dot GA14766 at domone dot podge> <201311300302 dot 33880 dot vapier at gentoo dot org> <20131202044959 dot GB14845 at spoyarek dot pnq dot redhat dot com>
On 12/01/2013 11:49 PM, Siddhesh Poyarekar wrote:
> On Sat, Nov 30, 2013 at 03:02:32AM -0500, Mike Frysinger wrote:
>> were you going to merge this as is then ? i agree this second cleanup should
>> happen, but i don't think it needs to happen with this obviously correct one.
>
> I agree that the additional __builtin_expect -> __glibc_{,un}likely
> conversions could happen as a separate patch. However, I would like
> to see the whitespace issues I pointed out fixed before the merge.
+1.
Cheers,
Carlos.