This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 4/4] getaddrinfo: rename 'name' to 'nodename' in getaddrinfo_inet()
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Pavel Simerda <psimerda at redhat dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>, Siddhesh Poyarekar <siddhesh at redhat dot com>
- Date: Mon, 9 Dec 2013 16:57:20 +0100
- Subject: Re: [PATCH 4/4] getaddrinfo: rename 'name' to 'nodename' in getaddrinfo_inet()
- Authentication-results: sourceware.org; auth=none
- References: <1921886851 dot 23954881 dot 1386596531453 dot JavaMail dot root at redhat dot com> <919982210 dot 23955005 dot 1386596561256 dot JavaMail dot root at redhat dot com>
On Mon, Dec 09, 2013 at 08:42:41AM -0500, Pavel Simerda wrote:
> Call the first parameter 'nodename' and avoid its modification
> throughout the whole function. Instead point 'name' to the same
> const string and optionally repoint it to the IDN encoded version
> later.
>
Change itself looks ok but I would like know if there is a follow-up as
this does not improve code much by itself.