This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix bug 15915, erroneous make rule for linkobj/libc.so.
- From: "Ryan S. Arnold" <ryan dot arnold at gmail dot com>
- To: Brooks Moses <bmoses at google dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Wed, 11 Dec 2013 22:07:25 -0600
- Subject: Re: [patch] Fix bug 15915, erroneous make rule for linkobj/libc.so.
- Authentication-results: sourceware.org; auth=none
- References: <CAOxa4KomMpMcTRhCQtT9cWNeZ7QbzxBwQNbTL=qvCcLjk1L6fQ at mail dot gmail dot com> <CAOxa4KpUcQOmKadisHmVTX-nxon-0uhoyGhDT-2U+Zx01va40Q at mail dot gmail dot com> <CAAKybw9ttZJG1MYwKeh-ap24yBQVHiYXz4wrQ-_xGm3x+2D7=w at mail dot gmail dot com> <CAOxa4KrBhdzNP9uzba=-hguu69VXZ2XwZunRiURgk2hrp7Duqg at mail dot gmail dot com> <1378744628 dot 5770 dot 349 dot camel at ubuntu-sellcey> <CAOxa4KpK2z5OrGG0XNLdMEtYXfpZChoBhHChgCmD0YuCbkQBgQ at mail dot gmail dot com> <1378757027 dot 5770 dot 352 dot camel at ubuntu-sellcey> <CAOxa4Kq=+157Do-KEgO16Kmf7iYfnNzqDELeJpPdoSFU1oDEmA at mail dot gmail dot com> <CAOxa4KqiE1k1Z10Y6VuA30L2ofSZ8-oLAEX8NL_UGi57xqy7qA at mail dot gmail dot com> <CAOxa4KoqxX4K2x3V0f2fE6pP6oY7GjnOX9t+NqvbKfyoerFVxg at mail dot gmail dot com> <20130924205626 dot 212812C08C at topped-with-meat dot com> <524201F6 dot 4060302 at google dot com> <20130925175815 dot EF26A2C097 at topped-with-meat dot com>
On Wed, Sep 25, 2013 at 12:58 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> lib: $(common-objpfx)libc.so
>> -
>> lib: $(common-objpfx)linkobj/libc.so
>
> Make these just one line while you're at it.
>
>> -# Use our own special initializer and finalizer files for libc.so.
>> +# Use our own special initializer and finalizer files for the libc.so libraries.
>
> Line too long (max 79 columns).
>
>
> Approved with those changes.
Hi Brooks,
Are you going to get this into 2.19 with Roland's suggestions? I've
been using your patch for a few weeks and it'd be nice to get it
upstream.
Cheers,
Ryan