This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ 15846][v2] Add error reporting (via errno) to getauxval().
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Brooks Moses <bmoses at google dot com>
- Cc: libc-alpha at sourceware dot org, Rich Felker <dalias at aerifal dot cx>, Paul Pluzhnikov <ppluzhnikov at google dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Wed, 18 Dec 2013 11:27:08 +0100
- Subject: Re: [PATCH][BZ 15846][v2] Add error reporting (via errno) to getauxval().
- Authentication-results: sourceware.org; auth=none
- References: <Pine dot LNX dot 4 dot 64 dot 1312101652490 dot 15324 at digraph dot polyomino dot org dot uk> <1386975725-15317-1-git-send-email-bmoses at google dot com>
On Fri, Dec 13, 2013 at 03:02:05PM -0800, Brooks Moses wrote:
> Ok, since the general approach seems plausible, here's a real patch.
>
> As discussed in the recent thread on my $EXEC_ORIGIN patch and in BZ
> 15846, getauxval() presently has no unambiguous way of reporting an
> error condition. It currently returns zero on error, but this may also
> be a valid result for some auxv entries. As there is no clear invalid
> result for all current and future auxv entries, this patch sets errno
> (following a suggestion in the BZ entry).
>
> This version of the patch also adds documentation and tests for the
> value-not-found conditions in getauxval(). Tested on x86_64 GNU/Linux.
>
> (Adding tests showed me that the patch was incomplete; it's no longer a
> "const" function because it has a side effect of changing errno, and
> until I removed __attribute_const__ from the declaration, GCC simply
> discarded the call to it in the test!)
>
> Ok to commit?
>
ok