This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] ptrace.h: add __ prefix to ptrace_peeksiginfo_args
- From: Andreas Jaeger <aj at suse dot de>
- To: Mike Frysinger <vapier at gentoo dot org>, libc-alpha at sourceware dot org
- Cc: Allan McRae <allan at archlinux dot org>
- Date: Sun, 05 Jan 2014 22:16:54 +0100
- Subject: Re: [PATCH] ptrace.h: add __ prefix to ptrace_peeksiginfo_args
- Authentication-results: sourceware.org; auth=none
- References: <1388956244-10077-1-git-send-email-vapier at gentoo dot org>
On 01/05/2014 10:10 PM, Mike Frysinger wrote:
> All the other ptrace structures in this file have a __ prefix except this
> new one. This in turn causes build problems for most packages that try to
> use ptrace such as strace:
>
> gcc -DHAVE_CONFIG_H -I. -I../.. -I../../linux/x86_64 -I../../linux \
> -I./linux -Wall -Wwrite-strings -g -O2 -MT process.o -MD -MP \
> -MF .deps/process.Tpo -c -o process.o ../../process.c
> In file included from ../../process.c:63:0:
> /usr/include/linux/ptrace.h:58:8: error: redefinition of 'struct ptrace_peeksiginfo_args'
> struct ptrace_peeksiginfo_args {
> ^
> In file included from ../../defs.h:159:0,
> from ../../process.c:37:
> /usr/include/sys/ptrace.h:191:8: note: originally defined here
> struct ptrace_peeksiginfo_args
> ^
>
> Since this struct was introduced in glibc-2.18, there shouldn't be any
> real regressions with adding the __ prefix.
Thanks Mike, this looks fine,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126