This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] ptrace.h: add __ prefix to ptrace_peeksiginfo_args
- From: Allan McRae <allan at archlinux dot org>
- To: Andreas Jaeger <aj at suse dot de>, Mike Frysinger <vapier at gentoo dot org>, libc-alpha at sourceware dot org
- Date: Mon, 06 Jan 2014 22:03:55 +1000
- Subject: Re: [PATCH] ptrace.h: add __ prefix to ptrace_peeksiginfo_args
- Authentication-results: sourceware.org; auth=none
- References: <1388956244-10077-1-git-send-email-vapier at gentoo dot org> <52C9CBC6 dot 5020804 at suse dot de>
On 06/01/14 07:16, Andreas Jaeger wrote:
> On 01/05/2014 10:10 PM, Mike Frysinger wrote:
>> All the other ptrace structures in this file have a __ prefix except this
>> new one. This in turn causes build problems for most packages that try to
>> use ptrace such as strace:
>>
>> gcc -DHAVE_CONFIG_H -I. -I../.. -I../../linux/x86_64 -I../../linux \
>> -I./linux -Wall -Wwrite-strings -g -O2 -MT process.o -MD -MP \
>> -MF .deps/process.Tpo -c -o process.o ../../process.c
>> In file included from ../../process.c:63:0:
>> /usr/include/linux/ptrace.h:58:8: error: redefinition of 'struct ptrace_peeksiginfo_args'
>> struct ptrace_peeksiginfo_args {
>> ^
>> In file included from ../../defs.h:159:0,
>> from ../../process.c:37:
>> /usr/include/sys/ptrace.h:191:8: note: originally defined here
>> struct ptrace_peeksiginfo_args
>> ^
>>
>> Since this struct was introduced in glibc-2.18, there shouldn't be any
>> real regressions with adding the __ prefix.
>
> Thanks Mike, this looks fine,
>
> Andreas
>
Is is worth adding a comment (perhaps only in in
sysdeps/unix/sysv/linux/sys/ptrace.h) to the effect that the prefix is
added to avoid conflict with linux/ptrace.h as a reminder we need unify
these headers later?
Allan