This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC: Fix gettimeofday ifunc selection
- From: Ryan Arnold <ryan dot arnold at linaro dot org>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Mon, 13 Jan 2014 17:09:22 -0600
- Subject: Re: [PATCH] PowerPC: Fix gettimeofday ifunc selection
- Authentication-results: sourceware.org; auth=none
- References: <52D4333A dot 1080805 at linux dot vnet dot ibm dot com>
On Mon, Jan 13, 2014 at 12:40 PM, Adhemerval Zanella
<azanella@linux.vnet.ibm.com> wrote:
> The IFUNC selector for gettimeofday runs before _libc_vdso_platform_setup where
> __vdso_gettimeofday is set. The selector then sets __gettimeofday (the internal
> version used within GLIBC) to use the system call version instead of the vDSO one.
> This patch changes the check if vDSO is available to get its value directly
> instead of rely on __vdso_gettimeofday.
>
> This patch changes it by getting the vDSO value directly. This is intended to be
> applied on top of 'PowerPC: Fix ftime gettimeofday internal call returning bogus'.
>
> Tested on PPC64 and PPC32.
>
> ---
>
> 2014-01-13 Adhemerval Zanella <azanella@linux.vnet.ibm.com>
>
> [BZ#16431]
> * sysdeps/unix/sysv/linux/powerpc/gettimeofday.c (__gettimeofday):
> Adjust the vDSO correctly for internal calls.
> * sysdeps/unix/sysv/linux/powerpc/time.c (time): Likewise.
>
Did the testcase used to discover the bug from
https://sourceware.org/bugzilla/show_bug.cgi?id=16430 make it into the
tree?
Ryan