This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: glibc 2.18 freeze!
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 20 Jan 2014 11:20:41 -0800
- Subject: Re: glibc 2.18 freeze!
- Authentication-results: sourceware.org; auth=none
- References: <51ACFE36 dot 5000603 at redhat dot com> <CAAKybw9ZuOKSpXgCGb5mFVHkKmrnUCKAdStg+i7+_ckUM9Qp2g at mail dot gmail dot com> <51ADFC0B dot 1060907 at linux dot vnet dot ibm dot com> <20130611183029 dot B62D52C0A2 at topped-with-meat dot com> <51B78382 dot 6000403 at linux dot vnet dot ibm dot com>
On Tue, Jun 11, 2013 at 1:07 PM, Adhemerval Zanella
<azanella@linux.vnet.ibm.com> wrote:
> On 11-06-2013 15:30, Roland McGrath wrote:
>>> I'd like also to add http://sourceware.org/ml/libc-alpha/2013-05/msg00878.html
>> We should have a BZ item to refer to about that issue. Please file one and
>> then repost your patch with the BZ# in the log entry. I'd also like to see
>> a GCC bug filed about getting a proper solution to that, perhaps along with
>> the other issue that came up about compiler-emitted calls from __builtin_*
>> calls polluting the name space.
>>
>>
>> Thanks,
>> Roland
>>
> I opened http://sourceware.org/bugzilla/show_bug.cgi?id=15605 to track it and updated
> patch is below. My patch however only fixes the check-localplt issue I observed in
> PPC32/PPC64 builds with GCC 4.8 + O3. The issue reported at
> <http://sourceware.org/ml/libc-alpha/2013-05/msg00730.html>http://sourceware.org/ml/libc-alpha/2013-05/msg00730.html needs another solution.
>
> ---
>
> 2013-06-11 Adhemerval Zanella <azanella@linux.vnet.ibm.com>
>
> [BZ #15605]
> * sysdeps/generic/symbol-hacks.h: Add workaround for memset/memmove calls
> generated by the compiler on loop optimizations.
> * sysdeps/wordsize-32/symbol-hacks.h: Include next symbol-hacks.h for
> general definitions.
>
In BZ #15605 fix with addding memset/memmove alias in symbol-hacks.h,
x32 symbol-hacks.h change was missing. Fixed by including
<sysdeps/generic/symbol-hacks.h> in x32 symbol-hacks.h. I checked it
into master and backported it into 2.18 branch.
H.J.
----
diff --git a/ChangeLog b/ChangeLog
index 74d4330..15ce0b6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2014-01-20 H.J. Lu <hongjiu.lu@intel.com>
+
+ [BZ #15605]
+ * sysdeps/x86_64/x32/symbol-hacks.h: Include generic symbol-hacks.h.
+
2014-01-04 Maxim Kuvyrkov <maxim@kugelworks.com>
OndÅej BÃlka <neleai@seznam.cz>
diff --git a/sysdeps/x86_64/x32/symbol-hacks.h
b/sysdeps/x86_64/x32/symbol-hacks.h
index bc7b4c4..22aad04 100644
--- a/sysdeps/x86_64/x32/symbol-hacks.h
+++ b/sysdeps/x86_64/x32/symbol-hacks.h
@@ -1 +1 @@
-/* Fortunately nothing to do. */
+#include <sysdeps/generic/symbol-hacks.h>