Re: [PING][RFC 3/*] Remove THREAD_STATS

[Mike Frysinger <vapier at gentoo dot org>]

On Saturday, February 08, 2014 01:11:13 OndÅej BÃlka wrote:
> On Mon, Dec 30, 2013 at 09:47:30PM +0530, Siddhesh Poyarekar wrote:
> > On 11 December 2013 17:49, OndÅej BÃlka <neleai@seznam.cz> wrote:
> > > Another macro in malloc is THREAD_STATS to print statistic about locking
> > > which duplicates malloc probes.
> > > 
> > > As this looks undocumented could it be removed?
> > > 
> > >         * malloc/arena.c (grow_heap, get_free_list, reused_arena,
> > >         arena_get2): Remove THREAD_STATS conditionals.
> > >         * malloc/malloc.c (__malloc_assert, __libc_realloc, _int_free,
> > >         __malloc_stats, int): Likewise.
> > 
> > It can be defined during build to print statistics of lock contention,
> > to demonstrate/verify the efficiency of the per-thread code.  I agree
> > that it could be removed, but I'd like the opinion of another
> > maintainer on this.
> 
> Do somebody else agree/disagree that it could be removed?

if the probes provide the same functionality, then let's kill this.  it 
defaults to off and i suspect the # of people who are enabling this can be 
counted on one hand.  the probe code is much cleaner to instrument with and 
this code is pretty ugly with its nested ifdefs.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.