This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/*] Expand arena_get macro.
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: OndÅej BÃlka <neleai at seznam dot cz>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 11 Feb 2014 10:10:02 +0530
- Subject: Re: [PATCH 2/*] Expand arena_get macro.
- Authentication-results: sourceware.org; auth=none
- References: <20131211102701 dot GA25483 at domone dot podge> <20131211113916 dot GA26438 at domone dot podge>
On Wed, Dec 11, 2013 at 12:39:16PM +0100, OndÅej BÃlka wrote:
> Hi,
>
> For thread local caches we would need to distinguish arena data from
> thread data. As this access was hidden in arena_get macro we expand it.
I'm not sure I understand why. Could you elaborate? There may be a
case for consolidating those macros, but I don't see the point in
actually breaking it down.
>
> This also could allow more simplification, is a check if arena is null
> now needeed?
>
The check is needed; that is how a thread asks for its own arena (or
share with someone else) when it doesn't have one in its pthread_key.
Siddhesh