This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] Move offset to end of file when fdopen is in "a" mode (#16532)
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: OndÅej BÃlka <neleai at seznam dot cz>
- Cc: Rich Felker <dalias at aerifal dot cx>, libc-alpha at sourceware dot org
- Date: Tue, 11 Feb 2014 15:56:39 +0530
- Subject: Re: [PATCH 1/2] Move offset to end of file when fdopen is in "a" mode (#16532)
- Authentication-results: sourceware.org; auth=none
- References: <20140211083800 dot GB1424 at spoyarek dot pnq dot redhat dot com> <20140211095455 dot GV15627 at brightrain dot aerifal dot cx> <20140211100558 dot GF1424 at spoyarek dot pnq dot redhat dot com> <20140211102231 dot GA8165 at domone dot podge>
On Tue, Feb 11, 2014 at 11:22:31AM +0100, OndÅej BÃlka wrote:
> > It shouldn't make a difference. The only reason to seek to the end is
> > to record the offset of the file end into the FILE object. If an
> > lseek moves it elsewhere, we don't care. Data will be appended to the
> > end of the file in any case since we add an O_APPEND to the fd.
> >
> How does that handle a+ mode? A offset should be at start but you need
> to write at end.
See Patch 2/2. That's where a+ is fixed.
Siddhesh