This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Added missing ICMPv6 flags and option
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Dan LÃdtke <maildanrl at gmail dot com>, libc-alpha at sourceware dot org
- Cc: Dan Luedtke <danrl at danrl dot de>
- Date: Wed, 12 Feb 2014 15:25:32 -0500
- Subject: Re: [PATCH] Added missing ICMPv6 flags and option
- Authentication-results: sourceware.org; auth=none
- References: <1392230153-23499-1-git-send-email-danrl at danrl dot de> <52FBC7DD dot 8020309 at redhat dot com> <CAAfuxnK0eAA1mA_fxhO4Oz9hWiV4yJ6FrZOGDC4j+1uv0OXHFQ at mail dot gmail dot com>
On 02/12/2014 02:31 PM, Dan LÃdtke wrote:
> Hi,
>
> On Wed, Feb 12, 2014 at 8:13 PM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 02/12/2014 07:35 PM, Dan Luedtke wrote:
>>> + * inet/netinet/icmp6.h: Added missing Router Advertisement Flags
>>> + * inet/netinet/icmp6.h: Added ICMPv6 Recursive DNS Server Option
>> This entry does not follow the usual format. You should list the
>> identifiers you changed.
> I did not change identifiers, did I? However, I have not contributed
> to glibc so I will read into how the community likes the ChangeLog
> best and change it according to the rules. Thanks for the hint.
https://sourceware.org/glibc/wiki/Contribution%20checklist
e.g.
* inet/netinet/icmp6.h (FOO): Define.
(FOO2): Likewise.
...
I'll let Florian comment on the other points.
Cheers,
Carlos.