This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [2.20] [2/6] Generate .test-result files for tests with special rules
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 14 Feb 2014 10:18:51 -0500
- Subject: Re: [2.20] [2/6] Generate .test-result files for tests with special rules
- Authentication-results: sourceware.org; auth=none
- References: <Pine dot LNX dot 4 dot 64 dot 1401100208000 dot 9412 at digraph dot polyomino dot org dot uk> <Pine dot LNX dot 4 dot 64 dot 1401100211060 dot 9412 at digraph dot polyomino dot org dot uk> <52FD9EDC dot 2040206 at redhat dot com> <Pine dot LNX dot 4 dot 64 dot 1402141317180 dot 643 at digraph dot polyomino dot org dot uk>
On 02/14/2014 08:21 AM, Joseph S. Myers wrote:
> On Thu, 13 Feb 2014, Carlos O'Donell wrote:
>
>>> * Should $(evaluate-test) go on the same line as the previous part of
>>> the command if it fits, or always on a separate line (or on a
>>> separate line unless the whole thing fits on a single line)? (Patch
>>> 1 uses a single line; this patch generally puts it on the same line
>>> as the previous part of the command if it fits.)
>>
>> Always on a separate line, though separate line unless the whole thing
>> fits is also OK.
>
> We need to decide this for the reworked version of patch 2 (which needs
> substantial rework following my cleanup patches in any case), as well as
> for patch 1 (current version
> <https://sourceware.org/ml/libc-alpha/2014-02/msg00429.html>). You prefer
> always on a separate line. Brooks
> <https://sourceware.org/ml/libc-alpha/2014-02/msg00287.html> prefers
> separate line unless the whole thing fits.
I like simple rules for mechanical things like formatting.
I suggest we stick to "always on a separate line" and move on.
Cheers,
Carlos.