This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Saturday, February 15, 2014 12:39:19 OndÅej BÃlka wrote: > On Fri, Feb 14, 2014 at 12:25:51PM -0500, Mike Frysinger wrote: > > On Thursday, February 13, 2014 13:38:12 OndÅej BÃlka wrote: > > > Hi, when reviewing Andreas patch I noticed duplicated code. One way to > > > improve that is jump to exit logic. A second possibility would be put > > > > > > gaih_getanswer into a else block. What do you prefer? > > > > i don't mind either, but i think generally the preference is to avoid goto > > when easily possible. so in this case, use the else. > > -mike > > OK, patch for this is following. It should cover one extra possibility when > __libc_res_nsearch fails and allocates separate buffer. OK -mike
Attachment:
signature.asc
Description: This is a digitally signed message part.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |