This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/*] Expand arena_get macro.

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: OndÅej BÃlka <neleai at seznam dot cz>
Cc: libc-alpha at sourceware dot org
Date: Fri, 21 Feb 2014 19:34:46 +0530
Subject: Re: [PATCH 2/*] Expand arena_get macro.
Authentication-results: sourceware.org; auth=none
References: <20131211102701 dot GA25483 at domone dot podge> <20131211113916 dot GA26438 at domone dot podge> <20140211044001 dot GB14750 at spoyarek dot pnq dot redhat dot com> <20140221120257 dot GB7772 at domone dot podge>

On Fri, Feb 21, 2014 at 01:02:57PM +0100, OndÅej BÃlka wrote:
> Simple in lockless implementation you want to get arena but not lock it.
> As macros are now they decrease readibility, you cannot use arena_lookup
> directly as it may be null so you would duplicate a arena_lock casing
> anyway, relevant macros are:

We don't have a lockless implementation right now.  IMO this change
might be more suitable as a precursor patch for a lockless
implementation when there is actually a patch for it which shows that
the macro removal is actually needed.

It's an opinion of course, since the macro expansion doesn't actually
change behaviour - it does affect QoI IMO, but that again is an
opinion.  If nobody else thinks this change needs more justification
then I don't think my opposition would be valid.

Siddhesh

Attachment: pgpwKt1T8eCI1.pgp
Description: PGP signature

References:
- Re: [PATCH 2/*] Expand arena_get macro.
  - From: Siddhesh Poyarekar
- Re: [PATCH 2/*] Expand arena_get macro.
  - From: OndÅej BÃlka

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]